Commit messages

July 31, 2014

jpritikin committed r3705 in OpenMx at 11:47:
Implement new unprotect strategy

The old idiom was

Rf_protect(foo);
// do stuff
Rf_unprotect(1);  //foo

The second line expresses the hope that we are unprotecting the same
thing that we protected. However, this can fail when "do stuff" involves
anything non-trivial. If there is a protect (or worse, an extra
unprotect) inside "do stuff" then the unprotect will not unprotect foo
but something else.

The new strategy is to check whether the protect stack is
at the same place where we protected, ensuring that our
protects are always balanced by unprotects. It is still
required to think about what is necessary to protect,
but now there is less chance of something going wrong
in the unprotect part.
in /trunk:

July 30, 2014

jpritikin committed r3703 in OpenMx at 13:12:
For summary(verbose=F), suppress SE and bounds if all NA
in /trunk/R: MxSummary.R (modified, previous: r3687)
jpritikin committed r3702 in OpenMx at 13:12:
MxDataDynamic pretty printing

July 29, 2014

tbates committed r3697 in OpenMx at 16:31:
minor error msg change: show user the verboten list of names
in /trunk/R: MxRAMModel.R (modified, previous: r3686)
jpritikin committed r3695 in OpenMx at 07:38:
Add fast path to matchDefinitionVariable
in /trunk/R: MxMatrix.R (modified, previous: r3694)
jpritikin committed r3694 in OpenMx at 07:38:
Do same work in fewer matches
in /trunk/R: MxMatrix.R (modified, previous: r3609)
jpritikin committed r3693 in OpenMx at 07:37:
Remove very expensive deadcode from MxFlatModel
jpritikin committed r3692 in OpenMx at 07:37:
If not found, don't search for defintion vars twice
in /trunk/R: MxRun.R (modified, previous: r3685)
jpritikin committed r3691 in OpenMx at 07:37:
Make checkVariablesHelper more efficient
in /trunk/R: MxFlatModel.R (modified, previous: r3609)
jpritikin committed r3690 in OpenMx at 07:37:
Don't blindly cast all NA columns to double

When the column is a factor, it needs to stay integer
in /trunk:
Syndicate content