Commit messages

July 31, 2014

jpritikin committed r3705 in OpenMx at 11:47:
Implement new unprotect strategy

The old idiom was

Rf_protect(foo);
// do stuff
Rf_unprotect(1);  //foo

The second line expresses the hope that we are unprotecting the same
thing that we protected. However, this can fail when "do stuff" involves
anything non-trivial. If there is a protect (or worse, an extra
unprotect) inside "do stuff" then the unprotect will not unprotect foo
but something else.

The new strategy is to check whether the protect stack is
at the same place where we protected, ensuring that our
protects are always balanced by unprotects. It is still
required to think about what is necessary to protect,
but now there is less chance of something going wrong
in the unprotect part.
in /trunk:
jpritikin committed r3704 in OpenMx at 11:46:
Use proper define to index freeVarGroups
in /trunk/src: omxImportFrontendState.cpp (modified, previous: r3696)

July 30, 2014

jpritikin committed r3701 in OpenMx at 07:21:
Add more unprotects
in /trunk/src: omxData.cpp (modified, previous: r3696)
jpritikin committed r3700 in OpenMx at 07:21:
Reorder initialization sequence
in /trunk/src: glue.cpp (modified, previous: r3675)
jpritikin committed r3699 in OpenMx at 07:21:
BA81: Cope with only mean or only cov (but not both)

July 29, 2014

jpritikin committed r3696 in OpenMx at 08:42:
Add some unprotects
jpritikin committed r3690 in OpenMx at 07:37:
Don't blindly cast all NA columns to double

When the column is a factor, it needs to stay integer
in /trunk:
jpritikin committed r3689 in OpenMx at 07:37:
Delete unsupported autodiff

On Mon, Jul 28, 2014 at 01:40:53AM -0400, Bob Carpenter wrote:
> The big problem with using Eigen directly is that it doesn't
> support mixed types (double and autodiff var) in its matrix operators.
> And you really don't want to autodiff the algorithms themselves
> if you don't have to --- a lot of the linear algebra operations have
> analytic gradients (as do the matrix operators).
  • AutoDiff (deleted: r3675)
  • src/AutoDiff/AutoDiffJacobian.h (deleted: r3675)
  • src/AutoDiff/AutoDiffScalar.h (deleted: r3675)
  • src/AutoDiff/AutoDiffVector.h (deleted: r3675)
  • src/AutoDiff/CMakeLists.txt (deleted: r3675)

July 27, 2014

jpritikin committed r3684 in OpenMx at 01:43:
Select SEM algorithm by name instead of number
in /trunk/src: Compute.cpp (modified, previous: r3683)
jpritikin committed r3683 in OpenMx at 01:43:
Permit more than 1 fitfunction in mxComputeOnce
in /trunk:
Syndicate content